Skip to content

Conversation

@eduolivares
Copy link
Contributor

The all-group.yml inventory file is regenerated during deployment, but this causes loss of inventory groups from previous operations (e.g., BGP routers, spines, leafs, undercloud nodes). This change extracts the all-group creation logic into a separate task file that checks for an existing file, slurps its content, generates the new template, and then recursively merges the children from both old and new files. This ensures all inventory groups are preserved across multiple deployment phases.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign amartyasinha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6c6e056351784d55a87189da324fd1eb

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 49s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 27m 05s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 39m 38s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 06m 40s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 12s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 22s
cifmw-pod-pre-commit FAILURE in 8m 38s
✔️ cifmw-molecule-libvirt_manager SUCCESS in 44m 10s
✔️ cifmw-molecule-reproducer SUCCESS in 16m 02s

@eduolivares eduolivares force-pushed the bgp-xl-adoption-tempest-2 branch from f062c9f to cdf6e95 Compare January 13, 2026 10:47
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6aec9d0728f146acb10ef4c6ff482065

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 24m 20s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 26m 06s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 40m 56s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 09m 46s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 01s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 45s
cifmw-pod-pre-commit FAILURE in 7m 55s
✔️ cifmw-molecule-libvirt_manager SUCCESS in 38m 38s
✔️ cifmw-molecule-reproducer SUCCESS in 14m 05s

@eduolivares eduolivares marked this pull request as ready for review January 15, 2026 11:29
@eduolivares eduolivares force-pushed the bgp-xl-adoption-tempest-2 branch from cdf6e95 to a5a3e1f Compare January 15, 2026 11:32
…ing all-group.yml

The all-group.yml inventory file is regenerated during deployment, but this
causes loss of inventory groups from previous operations (e.g., BGP routers,
spines, leafs, undercloud nodes). This change extracts the all-group creation
logic into a separate task file that checks for an existing file, slurps its
content, generates the new template, and then recursively merges the children
from both old and new files. This ensures all inventory groups are preserved
across multiple deployment phases.

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Signed-off-by: Eduardo Olivares <[email protected]>
@eduolivares eduolivares force-pushed the bgp-xl-adoption-tempest-2 branch from a5a3e1f to 661f1d1 Compare January 15, 2026 11:45
@danpawlik
Copy link
Contributor

I also added a feature to dump just libvirt VMs into a file - #3505

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a8ad75c9bacf4bfe8d1abb813c177776

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 21m 00s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 27m 59s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 30m 58s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 06m 21s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 46s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 41s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 04s
cifmw-molecule-libvirt_manager FAILURE in 5m 04s
✔️ cifmw-molecule-reproducer SUCCESS in 14m 33s

@eduolivares
Copy link
Contributor Author

recheck

@eduolivares eduolivares merged commit d43a10a into openstack-k8s-operators:main Jan 15, 2026
6 checks passed
@eduolivares eduolivares deleted the bgp-xl-adoption-tempest-2 branch January 15, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants